On set targeting #3203
Merged
On set targeting #3203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretg
requested changes
Oct 22, 2018
src/auctionManager.js
Outdated
| @@ -91,6 +91,9 @@ export function newAuctionManager() { | |||
| auctionManager.setStatusForBids = function(adId, status) { | |||
| let bid = auctionManager.findBidByAdId(adId); | |||
| if (bid) bid.status = status; | |||
|
|
|||
| const auction = find(_auctions, auction => auction.getAuctionId() === bid.auctionId); | |||
There was a problem hiding this comment.
This setStatusForBids function could get called for other statuses someday. Calling setBidTargeting needs to be done only when status is 'BID_TARGETING_SET'
|
Also need to consider how to add this to the unit tests. I can't find tests for the other event (onBidWon) in the spec files either, so we ought to add one for that too. Adding @jaiminpanchal27 for advise on unit tests. |
Added several tests for the following events: BidWon, SetTargeting, Timeout. |
jaiminpanchal27
approved these changes
Nov 1, 2018
jaiminpanchal27
added
LGTM
needs 2nd review
idettman
pushed a commit
to rubicon-project/Prebid.js
that referenced
this pull request
Nov 14, 2018
* Add onSetTargeting method to bid adapter spec * Reset context before each criteo adapter test * Add a unit test to check spec.onTimeout() is called * Add a unit test to check spec.onBidWon() is called * Add a unit test to check spec.onSetTargeting() is called * Remove unused adUnits argument from callSetTargetingBidder * Add integration test on onSetTargeting * Move Bid status constants from targeting.js to constants.json * Make sure onSetTargeting won't be called when the bid is not in status BID_TARGETING_SET
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* Add onSetTargeting method to bid adapter spec * Reset context before each criteo adapter test * Add a unit test to check spec.onTimeout() is called * Add a unit test to check spec.onBidWon() is called * Add a unit test to check spec.onSetTargeting() is called * Remove unused adUnits argument from callSetTargetingBidder * Add integration test on onSetTargeting * Move Bid status constants from targeting.js to constants.json * Make sure onSetTargeting won't be called when the bid is not in status BID_TARGETING_SET
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
* Add onSetTargeting method to bid adapter spec * Reset context before each criteo adapter test * Add a unit test to check spec.onTimeout() is called * Add a unit test to check spec.onBidWon() is called * Add a unit test to check spec.onSetTargeting() is called * Remove unused adUnits argument from callSetTargetingBidder * Add integration test on onSetTargeting * Move Bid status constants from targeting.js to constants.json * Make sure onSetTargeting won't be called when the bid is not in status BID_TARGETING_SET
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add onSetTargeting method to bid adapter spec
Corresponding change for prebid.org: prebid/prebid.github.io#1008